[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints
From: |
Pavel Dovgaluk |
Subject: |
Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints |
Date: |
Tue, 13 Jan 2015 12:15:54 +0300 |
> From: Pavel Dovgaluk [mailto:address@hidden
> > From: Paolo Bonzini [mailto:address@hidden
> > On 12/01/2015 13:01, Pavel Dovgalyuk wrote:
> > > + default:
> > > + case QEMU_CLOCK_VIRTUAL:
> > > + if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running())
> > > + || !replay_checkpoint(run_all ? 2 : 3)) {
> > > + return false;
> > > + }
> > > + break;
> >
> > Please document the meaning of the numbers by making an enum.
>
> The numbers have no meaning. They just have to be distinct in different
> places.
>
> > Why do you have to distinguish run_all?
>
> It seems to be early versions artifact. I'll remove it.
Sorry, missed one thing.
run_all is used to distinguish timers processed in AIO by calling of
timerlistgroup_run_timers function
and in main loop by calling qemu_clock_run_all_timers.
We need to distinguish that to secure the sequence of the events.
It makes sense when we use checkpointing while recording the execution.
Pavel Dovgalyuk
- Re: [Qemu-devel] [RFC PATCH v7 12/21] replay: recording and replaying clock ticks, (continued)
[Qemu-devel] [RFC PATCH v7 13/21] replay: recording and replaying different timers, Pavel Dovgalyuk, 2015/01/12
[Qemu-devel] [RFC PATCH v7 14/21] replay: shutdown event, Pavel Dovgalyuk, 2015/01/12
[Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints, Pavel Dovgalyuk, 2015/01/12
Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints, Pavel Dovgaluk, 2015/01/22
[Qemu-devel] [RFC PATCH v7 16/21] replay: bottom halves, Pavel Dovgalyuk, 2015/01/12
[Qemu-devel] [RFC PATCH v7 17/21] replay: replay aio requests, Pavel Dovgalyuk, 2015/01/12
[Qemu-devel] [RFC PATCH v7 18/21] replay: thread pool, Pavel Dovgalyuk, 2015/01/12
[Qemu-devel] [RFC PATCH v7 19/21] replay: initialization and deinitialization, Pavel Dovgalyuk, 2015/01/12