[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v3 30/38] coroutine: drop qemu_coroutine_adjust_pool_
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL v3 30/38] coroutine: drop qemu_coroutine_adjust_pool_size |
Date: |
Tue, 13 Jan 2015 13:48:08 +0000 |
From: Paolo Bonzini <address@hidden>
This is not needed anymore. The new TLS-based algorithm is adaptive.
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
block/block-backend.c | 4 ----
include/block/coroutine.h | 10 ----------
qemu-coroutine.c | 4 ----
3 files changed, 18 deletions(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index ef16d73..d00c129 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -260,9 +260,6 @@ int blk_attach_dev(BlockBackend *blk, void *dev)
blk_ref(blk);
blk->dev = dev;
bdrv_iostatus_reset(blk->bs);
-
- /* We're expecting I/O from the device so bump up coroutine pool size */
- qemu_coroutine_adjust_pool_size(COROUTINE_POOL_RESERVATION);
return 0;
}
@@ -290,7 +287,6 @@ void blk_detach_dev(BlockBackend *blk, void *dev)
blk->dev_ops = NULL;
blk->dev_opaque = NULL;
bdrv_set_guest_block_size(blk->bs, 512);
- qemu_coroutine_adjust_pool_size(-COROUTINE_POOL_RESERVATION);
blk_unref(blk);
}
diff --git a/include/block/coroutine.h b/include/block/coroutine.h
index 793df0e..20c027a 100644
--- a/include/block/coroutine.h
+++ b/include/block/coroutine.h
@@ -216,14 +216,4 @@ void coroutine_fn co_aio_sleep_ns(AioContext *ctx,
QEMUClockType type,
*/
void coroutine_fn yield_until_fd_readable(int fd);
-/**
- * Add or subtract from the coroutine pool size
- *
- * The coroutine implementation keeps a pool of coroutines to be reused by
- * qemu_coroutine_create(). This makes coroutine creation cheap. Heavy
- * coroutine users should call this to reserve pool space. Call it again with
- * a negative number to release pool space.
- */
-void qemu_coroutine_adjust_pool_size(int n);
-
#endif /* QEMU_COROUTINE_H */
diff --git a/qemu-coroutine.c b/qemu-coroutine.c
index 93fddc7..da1b961 100644
--- a/qemu-coroutine.c
+++ b/qemu-coroutine.c
@@ -143,7 +143,3 @@ void coroutine_fn qemu_coroutine_yield(void)
self->caller = NULL;
coroutine_swap(self, to);
}
-
-void qemu_coroutine_adjust_pool_size(int n)
-{
-}
--
2.1.0
- [Qemu-devel] [PULL v3 18/38] iotests: Filter out "I/O thread spun..." warning, (continued)
- [Qemu-devel] [PULL v3 18/38] iotests: Filter out "I/O thread spun..." warning, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 21/38] .gitignore: Ignore generated "common.env", Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 19/38] migration/block: fix pending() return value, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 22/38] qemu-iotests: Replace "/bin/true" with "true", Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 23/38] qemu-iotests: Add "_supported_os Linux" to 058, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 20/38] libqos: Convert malloc-pc allocator to a generic allocator, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 25/38] coroutine-ucontext: use __thread, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 24/38] qemu-iotests: Add supported os parameter for python tests, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 26/38] qemu-thread: add per-thread atexit functions, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 29/38] coroutine: rewrite pool to avoid mutex, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 30/38] coroutine: drop qemu_coroutine_adjust_pool_size,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL v3 27/38] test-coroutine: avoid overflow on 32-bit systems, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 28/38] QSLIST: add lock-free operations, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 32/38] block: limited request size in write zeroes unsupported path, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 33/38] block: Split BLOCK_OP_TYPE_COMMIT to BLOCK_OP_TYPE_COMMIT_{SOURCE, TARGET}, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 31/38] coroutine: try harder not to delete coroutines, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 34/38] ide: Implement VPD response for ATAPI, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 35/38] nvme: Fix get/set number of queues feature, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 38/38] NVMe: Set correct VS Value for 1.1 Compliant Controllers, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 36/38] MAINTAINERS: Update email addresses for Chrysostomos Nanakos, Stefan Hajnoczi, 2015/01/13
- [Qemu-devel] [PULL v3 37/38] MAINTAINERS: Add migration/block* to block subsystem, Stefan Hajnoczi, 2015/01/13