[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 6/9] rocker: add new rocker switch device
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3 6/9] rocker: add new rocker switch device |
Date: |
Thu, 15 Jan 2015 10:08:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 15/01/2015 00:20, Scott Feldman wrote:
> I tried setting .impl.max_access_size=4 and the Linux driver self-test
> fails on 64-bit reg write/read. 32-bit regs writes/reads are OK. On
> the 64-bit write/read, the self test writes a value and expects to
> read back 2x the value written. After making the change
> .impl.max_access_size=4, the reg reads back as 0, regardless of what
> was written.
It would be a bug. I can try to look at it later.
Paolo
> The driver uses writeq/readq for 64-bit writes/reads.
>
> I'm inclined to not change the device and leave .impl.max_access_size=8.
- [Qemu-devel] [PATCH v3 1/9] net: add MAC address string printer, (continued)
- [Qemu-devel] [PATCH v3 1/9] net: add MAC address string printer, sfeldma, 2015/01/10
- [Qemu-devel] [PATCH v3 4/9] pci: add rocker device ID, sfeldma, 2015/01/10
- [Qemu-devel] [PATCH v3 8/9] rocker: add tests, sfeldma, 2015/01/10
- [Qemu-devel] [PATCH v3 9/9] MAINTAINERS: add rocker, sfeldma, 2015/01/10
- [Qemu-devel] [PATCH v3 7/9] qmp: add rocker device support, sfeldma, 2015/01/10
- [Qemu-devel] [PATCH v3 6/9] rocker: add new rocker switch device, sfeldma, 2015/01/10
- Re: [Qemu-devel] [PATCH v3 6/9] rocker: add new rocker switch device, Jason Wang, 2015/01/16