[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/16] Block patches
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PULL 00/16] Block patches |
Date: |
Tue, 20 Jan 2015 10:26:47 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sat, Jan 17, 2015 at 11:41:59AM +0100, Peter Wu wrote:
> On Friday 16 January 2015 16:46:39 Peter Maydell wrote:
> > CentOS5:
> >
> > ../block/dmg.o: In function `dmg_read_plist_xml':
> > /home/petmay01/linaro/qemu-for-merges/block/dmg.c:414: undefined
> > reference to `g_base64_decode_inplace'
>
> Should have paid more attention to the API docs. Can you try the
> following patch? It still passes 4 dmg tests for me
> (https://lekensteyn.nl/files/dmg-tests/).
Could you also replace g_assert_false() with g_assert(!...) so it builds
on Mac?
Thanks,
Stefan
pgpenXfTaQLFg.pgp
Description: PGP signature
- [Qemu-devel] [PULL 08/16] block/dmg: set virtual size to a non-zero value, (continued)
- [Qemu-devel] [PULL 08/16] block/dmg: set virtual size to a non-zero value, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 12/16] block/dmg: support bzip2 block entry types, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 09/16] block/dmg: fix sector data offset calculation, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 14/16] qed: check for header size overflow, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 11/16] block/dmg: factor out block type check, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 15/16] qemu-iotests: add 116 invalid QED input file tests, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 13/16] block/dmg: improve zeroes handling, Stefan Hajnoczi, 2015/01/16
- [Qemu-devel] [PULL 16/16] qemu-iotests: Fix supported_oses check, Stefan Hajnoczi, 2015/01/16
- Re: [Qemu-devel] [PULL 00/16] Block patches, Peter Maydell, 2015/01/16