[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RESEND PATCH v1 0/5] Common unplug and unplug request
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [RESEND PATCH v1 0/5] Common unplug and unplug request cb for memory and CPU hot-unplug. |
Date: |
Tue, 20 Jan 2015 12:40:22 +0200 |
On Tue, Jan 20, 2015 at 11:03:02AM +0100, Igor Mammedov wrote:
> On Mon, 19 Jan 2015 23:29:37 +0200
> "Michael S. Tsirkin" <address@hidden> wrote:
>
> > On Wed, Jan 07, 2015 at 02:49:40PM +0800, Tang Chen wrote:
> > > Memory and CPU hot unplug are both asynchronize procedures.
> > > When the unplug operation happens, unplug request cb is called first.
> > > And when ghest OS finished handling unplug, unplug cb will be called
> > > to do the real removal of device.
> > >
> > > They both need pc-machine, piix4 and ich9 unplug and unplug request cb.
> > > So this patch set introduces these commom functions as part1, and memory
> > > and CPU hot-unplug will come soon as part 2 and 3.
> > >
> > > This patch-set is based on QEmu 2.2
> >
> > OK, Igor - you only have comments for the commit log?
> > I take this as implicit ack of the patches?
> > If so pls let me know.
> Yes, patches themselves are good.
> Can fixup commit messages and add author SoBs to them, before
> applying or should we wait for respin?
I didn't notice signatures were missing.
This is required for inclusion.
Tang Chen, please rebase on top of my pci branch, but also,
we don't include code of uncertain origin.
So - if you can certify the below:
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
then you add a line at the end of each commit message saying
Signed-off-by: Random J Developer <address@hidden>
for each developer who participated in writing this code.
>
> > > Tang Chen (5):
> > > acpi, pc: Add hotunplug request cb for pc machine.
> > > acpi, ich9: Add hotunplug request cb for ich9.
> > > acpi, pc: Add unplug cb for pc machine.
> > > acpi, ich9: Add unplug cb for ich9.
> > > acpi, piix4: Add unplug cb for piix4.
> > >
> > > hw/acpi/ich9.c | 14 ++++++++++++++
> > > hw/acpi/piix4.c | 8 ++++++++
> > > hw/i386/pc.c | 16 ++++++++++++++++
> > > hw/isa/lpc_ich9.c | 14 ++++++++++++--
> > > include/hw/acpi/ich9.h | 4 ++++
> > > 5 files changed, 54 insertions(+), 2 deletions(-)
> > >
> > > --
> > > 1.8.4.2
- [Qemu-devel] [RESEND PATCH v1 2/5] acpi, ich9: Add hotunplug request cb for ich9., (continued)
- [Qemu-devel] [RESEND PATCH v1 2/5] acpi, ich9: Add hotunplug request cb for ich9., Tang Chen, 2015/01/07
- [Qemu-devel] [RESEND PATCH v1 4/5] acpi, ich9: Add unplug cb for ich9., Tang Chen, 2015/01/07
- [Qemu-devel] [RESEND PATCH v1 5/5] acpi, piix4: Add unplug cb for piix4., Tang Chen, 2015/01/07
- [Qemu-devel] [RESEND PATCH v1 1/5] acpi, pc: Add hotunplug request cb for pc machine., Tang Chen, 2015/01/07
- Re: [Qemu-devel] [RESEND PATCH v1 0/5] Common unplug and unplug request cb for memory and CPU hot-unplug., Igor Mammedov, 2015/01/19
- Re: [Qemu-devel] [RESEND PATCH v1 0/5] Common unplug and unplug request cb for memory and CPU hot-unplug., Michael S. Tsirkin, 2015/01/19