Re: [Qemu-devel] [v6][PATCH 03/10] piix: create host bridge to passthrough

[Jike Song]

On 01/20/2015 10:52 AM, Chen, Tiejun wrote:
> On 2015/1/19 19:40, Gerd Hoffmann wrote:
> > On Mo, 2015-01-19 at 17:28 +0800, Tiejun Chen wrote:
> > > +static void xen_igd_passthrough_i440fx_class_init(ObjectClass *klass,
> > > +                                                  void *data)
> > > +{
> > > +    DeviceClass *dc = DEVICE_CLASS(klass);
> > > +
> > > +    dc->desc = "IGD PT XEN Host bridge";
> > > +}
> >
> > IMO "xen" naming should go away here too.

I would agree with this.

In fact, this piece of code could possibly be used by:

 a) IGD passthru for Xen and KVM, and/or:
 b) IGD Mediated passthru for Xen and KVM, i.e. XenGT/KVMGT

So it looks better if have "xen" naming purged :)

> Its easy to do but we need to wait KvmGT guys' response, so now it makes
> sense to leave "xen" as a prefix since this just work in xen side.
>
> Thanks
> Tiejun

--
Thanks,
Jike