[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] apic: do not dereference pointer before it is c
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] apic: do not dereference pointer before it is checked for NULL |
|
Date: |
Tue, 20 Jan 2015 13:36:42 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> Right now you only get to apic_init_reset if you have an APIC
> (do_cpu_init is reached only if CPU_INTERRUPT_INIT is set and
> that only happens in hw/intc/apic.c). However, this is wrong
> because for example a port 92 or keyboard controller reset is
> really an INIT, and that can happen also with no APIC. So
> keep the check and fix the error that Coverity reported.
>
> Reported-by: Markus Armbruster <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>