[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 1/6] block: vmdk - make ret variable usage clear
From: |
Jeff Cody |
Subject: |
[Qemu-devel] [PATCH v3 1/6] block: vmdk - make ret variable usage clear |
Date: |
Thu, 22 Jan 2015 08:03:25 -0500 |
Keep the variable 'ret' something that is returned by the function it is
defined in. For the return value of 'sscanf', use a more meaningful
variable name.
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: John Snow <address@hidden>
Signed-off-by: Jeff Cody <address@hidden>
---
block/vmdk.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 52cb888..dc6459c 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -785,6 +785,7 @@ static int vmdk_parse_extents(const char *desc,
BlockDriverState *bs,
const char *desc_file_path, Error **errp)
{
int ret;
+ int matches;
char access[11];
char type[11];
char fname[512];
@@ -796,6 +797,7 @@ static int vmdk_parse_extents(const char *desc,
BlockDriverState *bs,
BDRVVmdkState *s = bs->opaque;
VmdkExtent *extent;
+
while (*p) {
/* parse extent line in one of below formats:
*
@@ -805,23 +807,23 @@ static int vmdk_parse_extents(const char *desc,
BlockDriverState *bs,
* RW [size in sectors] VMFSSPARSE "file-name.vmdk"
*/
flat_offset = -1;
- ret = sscanf(p, "%10s %" SCNd64 " %10s \"%511[^\n\r\"]\" %" SCNd64,
- access, §ors, type, fname, &flat_offset);
- if (ret < 4 || strcmp(access, "RW")) {
+ matches = sscanf(p, "%10s %" SCNd64 " %10s \"%511[^\n\r\"]\" %" SCNd64,
+ access, §ors, type, fname, &flat_offset);
+ if (matches < 4 || strcmp(access, "RW")) {
goto next_line;
} else if (!strcmp(type, "FLAT")) {
- if (ret != 5 || flat_offset < 0) {
+ if (matches != 5 || flat_offset < 0) {
error_setg(errp, "Invalid extent lines: \n%s", p);
return -EINVAL;
}
} else if (!strcmp(type, "VMFS")) {
- if (ret == 4) {
+ if (matches == 4) {
flat_offset = 0;
} else {
error_setg(errp, "Invalid extent lines:\n%s", p);
return -EINVAL;
}
- } else if (ret != 4) {
+ } else if (matches != 4) {
error_setg(errp, "Invalid extent lines:\n%s", p);
return -EINVAL;
}
--
1.9.3
- [Qemu-devel] [PATCH v3 0/6] Update filename string sizes in block layer, Jeff Cody, 2015/01/22
- [Qemu-devel] [PATCH v3 1/6] block: vmdk - make ret variable usage clear,
Jeff Cody <=
- [Qemu-devel] [PATCH v3 2/6] block: vmdk - move string allocations from stack to the heap, Jeff Cody, 2015/01/22
- [Qemu-devel] [PATCH v3 3/6] block: qapi - move string allocation from stack to the heap, Jeff Cody, 2015/01/22
- [Qemu-devel] [PATCH v3 5/6] block: mirror - change string allocation to 2-bytes, Jeff Cody, 2015/01/22
- [Qemu-devel] [PATCH v3 4/6] block: remove unused variable in bdrv_commit, Jeff Cody, 2015/01/22
- [Qemu-devel] [PATCH v3 6/6] block: update string sizes for filename, backing_file, exact_filename, Jeff Cody, 2015/01/22
- Re: [Qemu-devel] [PATCH v3 0/6] Update filename string sizes in block layer, Kevin Wolf, 2015/01/23