[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/15] memory: remove assertion on memory_region
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH 05/15] memory: remove assertion on memory_region_destroy |
Date: |
Mon, 26 Jan 2015 14:04:21 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, 01/22 15:47, Paolo Bonzini wrote:
> From: Jan Kiszka <address@hidden>
>
> Now that memory_region_destroy can be called from an RCU callback,
> checking the BQL-protected global memory_region_transaction_depth
> does not make much sense.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> memory.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/memory.c b/memory.c
> index c343bf3..8c3d8c0 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -1263,7 +1263,6 @@ static void memory_region_finalize(Object *obj)
> MemoryRegion *mr = MEMORY_REGION(obj);
>
> assert(QTAILQ_EMPTY(&mr->subregions));
> - assert(memory_region_transaction_depth == 0);
> mr->destructor(mr);
> memory_region_clear_coalescing(mr);
> g_free((char *)mr->name);
> --
> 1.8.3.1
>
>
Reviewed-by: Fam Zheng <address@hidden>
- [Qemu-devel] [PATCH v2 00/15] RCUification of the memory API, parts 1 and 2, Paolo Bonzini, 2015/01/22
- [Qemu-devel] [PATCH 02/15] rcu: add rcutorture, Paolo Bonzini, 2015/01/22
- [Qemu-devel] [PATCH 01/15] rcu: add rcu library, Paolo Bonzini, 2015/01/22
- [Qemu-devel] [PATCH 03/15] rcu: allow nesting of rcu_read_lock/rcu_read_unlock, Paolo Bonzini, 2015/01/22
- [Qemu-devel] [PATCH 05/15] memory: remove assertion on memory_region_destroy, Paolo Bonzini, 2015/01/22
- Re: [Qemu-devel] [PATCH 05/15] memory: remove assertion on memory_region_destroy,
Fam Zheng <=
- [Qemu-devel] [PATCH 06/15] memory: protect current_map by RCU, Paolo Bonzini, 2015/01/22
- [Qemu-devel] [PATCH 08/15] exec: introduce cpu_reload_memory_map, Paolo Bonzini, 2015/01/22
- [Qemu-devel] [PATCH 10/15] exec: RCUify AddressSpaceDispatch, Paolo Bonzini, 2015/01/22
- [Qemu-devel] [PATCH 04/15] rcu: add call_rcu, Paolo Bonzini, 2015/01/22
- [Qemu-devel] [PATCH 07/15] memory: avoid ref/unref in memory_region_find, Paolo Bonzini, 2015/01/22