[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/19] pc: fix KVM features in pc-1.3 and earlier mac
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 01/19] pc: fix KVM features in pc-1.3 and earlier machine types |
Date: |
Mon, 26 Jan 2015 10:24:12 +0100 |
Due to a typo, instead of disabling KVM_FEATURE_PV_EOI (bit
6) these machine types are disabling bits 1 and 2, which are
KVM_FEATURE_NOP_IO_DELAY and KVM_FEATURE_MMU_OP. Not a big deal
because they aren't very important and KVM_FEATURE_MMU_OP is
disabled anyway. The worst part is actually that KVM_FEATURE_PV_EOI
is remaining enabled.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/i386/pc_piix.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index f0a3201..97a754e 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -406,7 +406,7 @@ static void pc_compat_1_3(MachineState *machine)
static void pc_compat_1_2(MachineState *machine)
{
pc_compat_1_3(machine);
- x86_cpu_compat_kvm_no_autoenable(FEAT_KVM, KVM_FEATURE_PV_EOI);
+ x86_cpu_compat_kvm_no_autoenable(FEAT_KVM, 1 << KVM_FEATURE_PV_EOI);
}
static void pc_init_pci_2_2(MachineState *machine)
@@ -483,7 +483,7 @@ static void pc_init_isa(MachineState *machine)
if (!machine->cpu_model) {
machine->cpu_model = "486";
}
- x86_cpu_compat_kvm_no_autoenable(FEAT_KVM, KVM_FEATURE_PV_EOI);
+ x86_cpu_compat_kvm_no_autoenable(FEAT_KVM, 1 << KVM_FEATURE_PV_EOI);
enable_compat_apic_id_mode();
pc_init1(machine, 0, 1);
}
--
1.8.3.1
- [Qemu-devel] [PULL 00/19] i386, KVM, misc changes for 2015-01-26, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 03/19] multiboot: Fix offset of bootloader name, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 04/19] tests/multiboot: Add test for modules, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 05/19] target-i386: use vmstate_offset_sub_array for AVX registers, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 06/19] target-i386: make xmm_regs 512-bit wide, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 01/19] pc: fix KVM features in pc-1.3 and earlier machine types,
Paolo Bonzini <=
- [Qemu-devel] [PULL 07/19] qemu-timer: add timer_init and timer_init_ns/us/ms, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 09/19] vmstate: accept QEMUTimer in VMSTATE_TIMER*, add VMSTATE_TIMER_PTR*, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 02/19] tests/multiboot: Update reference output, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 11/19] kvm_stat: Add aarch64 support, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 14/19] apic: do not dereference pointer before it is checked for NULL, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 10/19] hw: misc, add educational driver, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 15/19] .travis.yml: Add "--enable-modules", Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 08/19] qemu-timer: introduce timer_deinit, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 17/19] sparse: Fix build with sparse on .S files, Paolo Bonzini, 2015/01/26
- [Qemu-devel] [PULL 19/19] kvm_stat: Add RESET support for perf event ioctl, Paolo Bonzini, 2015/01/26