[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] nbd: iotest fixes and error message improve
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] nbd: iotest fixes and error message improvement |
Date: |
Tue, 27 Jan 2015 10:05:41 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 27/01/2015 03:02, Max Reitz wrote:
> This series is a follow-up to my previous patch "iotests: Specify format
> for qemu-nbd" and as such relies on it.
>
> The first three patches of this series fix the qemu-iotests so they once
> again pass when using NBD.
>
> The fourth patch of this series improves NBD's error message for
> establishing connections, especially if the server's and the client's
> NBD version differs (which, until now, was simply "Bad magic received").
Good idea!
> Max Reitz (4):
> iotests: Fix 083
> iotests: Fix 100 for nbd
> iotests: Fix 104 for NBD
> nbd: Improve error messages
>
> block/nbd-client.c | 4 +-
> block/nbd-client.h | 2 +-
> block/nbd.c | 2 +-
> include/block/nbd.h | 2 +-
> nbd.c | 42 ++++++++++++---------
> qemu-nbd.c | 7 +++-
> tests/qemu-iotests/083 | 3 +-
> tests/qemu-iotests/083.out | 81
> ++++++++++++++--------------------------
> tests/qemu-iotests/100 | 12 ++++++
> tests/qemu-iotests/104 | 9 ++---
> tests/qemu-iotests/common.filter | 1 +
> 11 files changed, 82 insertions(+), 83 deletions(-)
>
Reviewed-by: Paolo Bonzini <address@hidden>