[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] vnc: g_realloc() can't fail, bury dead erro
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] vnc: g_realloc() can't fail, bury dead error handling |
Date: |
Tue, 27 Jan 2015 18:17:55 +0100 |
On Tue, 27 Jan 2015 17:38:30 +0100
Markus Armbruster <address@hidden> wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> ui/vnc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index a742c90..02552ee 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -659,10 +659,6 @@ void buffer_reserve(Buffer *buffer, size_t len)
> if ((buffer->capacity - buffer->offset) < len) {
> buffer->capacity += (len + 1024);
> buffer->buffer = g_realloc(buffer->buffer, buffer->capacity);
> - if (buffer->buffer == NULL) {
> - fprintf(stderr, "vnc: out of memory\n");
> - exit(1);
> - }
> }
> }
>
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH 0/6] Trivial cleanups around g_malloc(), Markus Armbruster, 2015/01/27
- [Qemu-devel] [PATCH 6/6] translate-all: Use g_try_malloc() for dynamic translator buffer, Markus Armbruster, 2015/01/27
- [Qemu-devel] [PATCH 2/6] rtl8139: g_malloc() can't fail, bury dead error handling, Markus Armbruster, 2015/01/27
- [Qemu-devel] [PATCH 3/6] kvm: g_malloc() can't fail, bury dead error handling, Markus Armbruster, 2015/01/27
- [Qemu-devel] [PATCH 1/6] onenand: g_malloc() can't fail, bury dead error handling, Markus Armbruster, 2015/01/27
- [Qemu-devel] [PATCH 5/6] vnc: g_realloc() can't fail, bury dead error handling, Markus Armbruster, 2015/01/27
- Re: [Qemu-devel] [PATCH 5/6] vnc: g_realloc() can't fail, bury dead error handling,
Thomas Huth <=
- [Qemu-devel] [PATCH 4/6] rdma: g_malloc0() can't fail, bury dead error handling, Markus Armbruster, 2015/01/27
- Re: [Qemu-devel] [PATCH 0/6] Trivial cleanups around g_malloc(), Eric Blake, 2015/01/27
- Re: [Qemu-devel] [PATCH 0/6] Trivial cleanups around g_malloc(), Markus Armbruster, 2015/01/28