qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 13/14] block: Remove "growable" from BDS


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3 13/14] block: Remove "growable" from BDS
Date: Tue, 27 Jan 2015 10:29:35 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 01/26/2015 08:00 AM, Max Reitz wrote:
> Now that request clamping is done in the BlockBackend, the "growable"
> field can be removed from the BlockDriverState. All BDSs are now treated
> as being "growable" (that is, they are allowed to grow; they are not
> necessarily actually able to).
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---

> +++ b/include/block/block_int.h
> @@ -369,9 +369,6 @@ struct BlockDriverState {
>      /* I/O Limits */
>      BlockLimits bl;
>  
> -    /* Whether the disk can expand beyond total_sectors */
> -    int growable;
> -

Yay - getting rid of an 'int' that was only used to hold 'bool' values :)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]