[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/50] hw/usb-storage: Check whether BB is inser
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 04/50] hw/usb-storage: Check whether BB is inserted |
Date: |
Tue, 27 Jan 2015 12:05:13 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 01/26/2015 09:02 AM, Max Reitz wrote:
> Only call bdrv_key_required() on the BlockDriverState if the
> BlockBackend has an inserted medium.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> hw/usb/dev-storage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c
> index 4539733..3123baf 100644
> --- a/hw/usb/dev-storage.c
> +++ b/hw/usb/dev-storage.c
> @@ -638,7 +638,7 @@ static void usb_msd_realize_storage(USBDevice *dev, Error
> **errp)
> usb_msd_handle_reset(dev);
> s->scsi_dev = scsi_dev;
>
> - if (bdrv_key_required(blk_bs(blk))) {
> + if (blk_is_inserted(blk) && bdrv_key_required(blk_bs(blk))) {
> if (cur_mon) {
> monitor_read_bdrv_key_start(cur_mon, blk_bs(blk),
> usb_msd_password_cb, s);
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/50] blockdev: BlockBackend and media, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 04/50] hw/usb-storage: Check whether BB is inserted, Max Reitz, 2015/01/26
- Re: [Qemu-devel] [PATCH 04/50] hw/usb-storage: Check whether BB is inserted,
Eric Blake <=
- [Qemu-devel] [PATCH 08/50] block/quorum: Implement bdrv_is_inserted(), Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 05/50] block: Fix BB AIOCB AioContext without BDS, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 01/50] blockdev: Allow creation of BDS trees without BB, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 03/50] hw/block/fdc: Implement tray status, Max Reitz, 2015/01/26
- [Qemu-devel] [PATCH 02/50] iotests: Only create BB if necessary, Max Reitz, 2015/01/26