qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RESEND 50/50] iotests: Add test for change-relat


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH RESEND 50/50] iotests: Add test for change-related QMP commands
Date: Wed, 28 Jan 2015 17:02:10 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 2015-01-28 at 16:57, Eric Blake wrote:
On 01/27/2015 12:46 PM, Max Reitz wrote:
Signed-off-by: Max Reitz <address@hidden>
---
  tests/qemu-iotests/118     | 649 +++++++++++++++++++++++++++++++++++++++++++++
  tests/qemu-iotests/118.out |   5 +
  tests/qemu-iotests/group   |   1 +
  3 files changed, 655 insertions(+)
  create mode 100755 tests/qemu-iotests/118
  create mode 100644 tests/qemu-iotests/118.out

Looks like lots of useful tests and good coverage, including things like
no-op open of an already open tray.  I didn't spot any obvious flaws
(but my python is weak), or think of any obvious missing tests, so feel
free to add:

Reviewed-by: Eric Blake <address@hidden>

Thank you very much for reviewing this series! I really did not think someone would jump on this so fast. :-)

Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]