[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/11] target-arm/translate-a64: Fix wrong mm
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/11] target-arm/translate-a64: Fix wrong mmu_idx usage for LDT/STT |
Date: |
Fri, 30 Jan 2015 09:49:39 +1000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jan 29, 2015 at 06:55:09PM +0000, Peter Maydell wrote:
> The LDT/STT (load/store unprivileged) instruction decode was using
> the wrong MMU index value. This meant that instead of these insns
> being "always access as if user-mode regardless of current privilege"
> they were "always access as if kernel-mode regardless of current
> privilege". This went unnoticed because AArch64 Linux doesn't use
> these instructions.
>
> Cc: address@hidden
>
> Signed-off-by: Peter Maydell <address@hidden>
> Reviewed-by: Greg Bellows <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
> ---
> I'm not counting this as a security issue because I'm assuming
> nobody treats TCG guests as a security boundary (certainly I
> would not recommend doing so...)
> ---
> target-arm/translate-a64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> index 80d2359..dac2f63 100644
> --- a/target-arm/translate-a64.c
> +++ b/target-arm/translate-a64.c
> @@ -2107,7 +2107,7 @@ static void disas_ldst_reg_imm9(DisasContext *s,
> uint32_t insn)
> }
> } else {
> TCGv_i64 tcg_rt = cpu_reg(s, rt);
> - int memidx = is_unpriv ? 1 : get_mem_index(s);
> + int memidx = is_unpriv ? MMU_USER_IDX : get_mem_index(s);
>
> if (is_store) {
> do_gpr_st_memidx(s, tcg_rt, tcg_addr, size, memidx);
> --
> 1.9.1
>
- Re: [Qemu-devel] [PATCH v2 06/11] target-arm: Don't define any MMU_MODE*_SUFFIXes, (continued)
- [Qemu-devel] [PATCH v2 02/11] target-arm: Make arm_current_el() return sensible values for M profile, Peter Maydell, 2015/01/29
- [Qemu-devel] [PATCH v2 11/11] target-arm: Fix brace style in reindented code, Peter Maydell, 2015/01/29
- [Qemu-devel] [PATCH v2 10/11] target-arm: Reindent ancient page-table-walk code, Peter Maydell, 2015/01/29
- [Qemu-devel] [PATCH v2 08/11] target-arm: Pass mmu_idx to get_phys_addr(), Peter Maydell, 2015/01/29
- [Qemu-devel] [PATCH v2 01/11] cpu_ldst.h: Allow NB_MMU_MODES to be 7, Peter Maydell, 2015/01/29
- [Qemu-devel] [PATCH v2 03/11] target-arm/translate-a64: Fix wrong mmu_idx usage for LDT/STT, Peter Maydell, 2015/01/29
- Re: [Qemu-devel] [PATCH v2 03/11] target-arm/translate-a64: Fix wrong mmu_idx usage for LDT/STT,
Edgar E. Iglesias <=
- [Qemu-devel] [PATCH v2 09/11] target-arm: Use mmu_idx in get_phys_addr(), Peter Maydell, 2015/01/29
- [Qemu-devel] [PATCH v2 04/11] target-arm: Define correct mmu_idx values and pass them in TB flags, Peter Maydell, 2015/01/29
- [Qemu-devel] [PATCH v2 07/11] target-arm: Split AArch64 cases out of ats_write(), Peter Maydell, 2015/01/29
- [Qemu-devel] [PATCH v2 05/11] target-arm: Use correct mmu_idx for unprivileged loads and stores, Peter Maydell, 2015/01/29
- Re: [Qemu-devel] [PATCH v2 00/11] target-arm: handle mmu_idx/translation regimes properly, Edgar E. Iglesias, 2015/01/29