[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v3 2/5] Qemu-Xen-vTPM: Xen frontend driver infrastruct
From: |
Xu, Quan |
Subject: |
Re: [Qemu-devel] [v3 2/5] Qemu-Xen-vTPM: Xen frontend driver infrastructure |
Date: |
Fri, 30 Jan 2015 01:46:18 +0000 |
> > > I think that the xenstore_update function should be moved to a new file:
> > > we don't want xen_backend.c to be handling any frontend updates.
> > > Maybe you could create a new file, hw/xen/xen_pvdev.c?
> > >
> >
> > Stefano,
> > I'd like to create hw/xen/xen_pvdev.c , include/hw/xen/ xen_pvdev.h
> > and include/hw/xen/xen_frontend.h
> >
> > include/hw/xen/ xen_pvdev.h is for
> > struct XenDevOps{} and struct XenDevice {} definition and some other macro.
> >
> > include/hw/xen/xen_frontend.h is for
> > xen frontend interface, such as xen_fe_register() .etc
> >
> > hw/xen/xen_pvdev.c is for
> > some general parts of xen_backend/xen_frontend.
> > It includes xenstore_update function xendevs management, such as
> > xen_qtail_insert_xendev(..),
> > xenstore_update(...) .etc.
> >
> > do you agree with it?
>
> It seems reasonable.
Thanks, I will do it ASAP. Now I have fixed most of comments.
-Quan