[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] quorum: don't share qiov
From: |
Wen Congyang |
Subject: |
[Qemu-devel] [PATCH] quorum: don't share qiov |
Date: |
Fri, 30 Jan 2015 16:07:16 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
If the child touches qiov->iov, it will cause unexpected results.
Signed-off-by: Wen Congyang <address@hidden>
---
block/quorum.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/block/quorum.c b/block/quorum.c
index cdc026c..ef0c1e9 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -165,6 +165,10 @@ static void quorum_aio_finalize(QuorumAIOCB *acb)
qemu_vfree(acb->qcrs[i].buf);
qemu_iovec_destroy(&acb->qcrs[i].qiov);
}
+ } else {
+ for (i = 0; i <= acb->child_iter; i++) {
+ qemu_iovec_destroy(&acb->qcrs[i].qiov);
+ }
}
g_free(acb->qcrs);
@@ -709,8 +713,12 @@ static BlockAIOCB *quorum_aio_writev(BlockDriverState *bs,
cb, opaque);
int i;
+ acb->child_iter = s->num_children - 1;
for (i = 0; i < s->num_children; i++) {
- acb->qcrs[i].aiocb = bdrv_aio_writev(s->bs[i], sector_num, qiov,
+ qemu_iovec_init(&acb->qcrs[i].qiov, acb->qiov->niov);
+ qemu_iovec_concat(&acb->qcrs[i].qiov, acb->qiov, 0, acb->qiov->size);
+ acb->qcrs[i].aiocb = bdrv_aio_writev(s->bs[i], sector_num,
+ &acb->qcrs[i].qiov,
nb_sectors, &quorum_aio_cb,
&acb->qcrs[i]);
}
--
2.1.0
- [Qemu-devel] [PATCH] quorum: don't share qiov,
Wen Congyang <=