[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command l
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line |
Date: |
Fri, 30 Jan 2015 09:56:31 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* Paolo Bonzini (address@hidden) wrote:
>
>
> On 30/01/2015 10:38, Dr. David Alan Gilbert wrote:
> > * Eric Blake (address@hidden) wrote:
> >> On 01/29/2015 01:21 PM, Dr. David Alan Gilbert wrote:
> >>> * Eric Blake (address@hidden) wrote:
> >>>> On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote:
> >>>>>
> >>>>> So what would the .args_type look like in qmp-commands.hx; something
> >>>>> like this?
> >>>>>
> >>>>> .args-type = "type:s,port:-i,host:-s,command:-s"
> >>>>
> >>>> No, it would be more like the blockdev-add interface, where one command
> >>>> accepts a dictionary object containing a union of valid values, where
> >>>> the set of valid values is determined by the discriminator field.
> >>>> .args_type = "options:q".
> >>>
> >>> What causes the parser to generate a 'BlockdevOptions' as opposed to any
> >>> standard options type for the parameter of qmp_blockdev_add?
> >>
> >> Kevin Wolf has the most experience here, as he was the one that figured
> >> out how to correlate command line and QMP as part of adding blockdev-add.
> >
> > OK, this is getting more complicated than I'd expected; how about a simpler
> > suggestion.
> >
> > The current suggestion is:
> > Modify -incoming to take 'pause' as an argument
>
> -S is just the same.
No it's not; it goes into a different state; see previous part of thread;
it's the difference between RUN_STATE_PAUSED and RUN_STATE_INMIGRATE.
> > Add migrate-incoming command that takes parsed URI
> >
> > New suggestion:
> > Modify -incoming to take a pause: prefix (e.g. -incoming
> > pause:tcp:host:port )
> > Add migrate-incoming-start command (takes no arguments).
>
> Another suggestion:
>
> Add incoming argument to the existing URI-based command migrate.
Yep, that's also possible if others are happy with it.
> Later on, if ever, add start-migration command that takes structured
> options, make HMP and QMP migrate wrappers for start-migration.
Dave
> Paolo
>
> > It seems simpler.
> >
> > Dave
> >
> >>
> >> --
> >> Eric Blake eblake redhat com +1-919-301-3266
> >> Libvirt virtualization library http://libvirt.org
> >>
> >
> >
> > --
> > Dr. David Alan Gilbert / address@hidden / Manchester, UK
> >
> >
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, (continued)
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Daniel P. Berrange, 2015/01/29
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Eric Blake, 2015/01/29
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Dr. David Alan Gilbert, 2015/01/29
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Eric Blake, 2015/01/29
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Dr. David Alan Gilbert, 2015/01/29
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Eric Blake, 2015/01/29
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Dr. David Alan Gilbert, 2015/01/29
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Eric Blake, 2015/01/29
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Dr. David Alan Gilbert, 2015/01/30
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Paolo Bonzini, 2015/01/30
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line,
Dr. David Alan Gilbert <=
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Daniel P. Berrange, 2015/01/30
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Markus Armbruster, 2015/01/30
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Dr. David Alan Gilbert, 2015/01/30
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Markus Armbruster, 2015/01/30
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Markus Armbruster, 2015/01/30
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Dr. David Alan Gilbert, 2015/01/29
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Daniel P. Berrange, 2015/01/29
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Dr. David Alan Gilbert, 2015/01/29
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Eric Blake, 2015/01/29
- Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line, Dr. David Alan Gilbert, 2015/01/29