[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v8 04/21] replay: internal functions for rep
From: |
Mark Burton |
Subject: |
Re: [Qemu-devel] [RFC PATCH v8 04/21] replay: internal functions for replay log |
Date: |
Fri, 30 Jan 2015 14:11:29 +0100 |
I believe thats what we concluded too
Cheers
Mark.
> On 30 Jan 2015, at 14:06, Paolo Bonzini <address@hidden> wrote:
>
>
>
> On 30/01/2015 13:56, Pavel Dovgaluk wrote:
>>> Could this be static? (I haven't checked).
>>
>> No, because it is used from several replay files.
>
> I wonder if that's a layering violation.
>
>>> Perhaps qemu_system_vmstop_request_prepare +
>>> qemu_system_vmstop_request(RUN_STATE_PAUSED) instead of exit? Those two
>>> functions are thread-safe.
>>
>> There is no need to stop when replay file is over (because we cannot replay
>> more).
>> Should we send shutdown request instead?
>
> I thought about it. I think no, because shutdown is irreversible (see
> runstate_needs_reset). Just pausing seemed to be the right compromise,
> and then the next "cont" can run the VM out of replay mode.
>
> Paolo
+44 (0)20 7100 3485 x 210
+33 (0)5 33 52 01 77x 210
+33 (0)603762104
mark.burton
- Re: [Qemu-devel] [RFC PATCH v8 02/21] replay: global variables and function stubs, (continued)
[Qemu-devel] [RFC PATCH v8 06/21] replay: introduce icount event, Pavel Dovgalyuk, 2015/01/22
[Qemu-devel] [RFC PATCH v8 07/21] cpu-exec: allow temporary disabling icount, Pavel Dovgalyuk, 2015/01/22
[Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence, Pavel Dovgalyuk, 2015/01/22
[Qemu-devel] [RFC PATCH v8 09/21] replay: interrupts and exceptions, Pavel Dovgalyuk, 2015/01/22
[Qemu-devel] [RFC PATCH v8 10/21] replay: asynchronous events infrastructure, Pavel Dovgalyuk, 2015/01/22
[Qemu-devel] [RFC PATCH v8 11/21] replay: recording and replaying clock ticks, Pavel Dovgalyuk, 2015/01/22