Re: [Qemu-devel] [PATCH 0/4] timer/m48t59: QOM'ify

[Mark Cave-Ayland]

On 19/01/15 21:59, Hervé Poussineau wrote:

> Hi,
> 
> This patchset QOM'ifies the m48t59 timer.
> Patch 1 allows the creation of the m4859 ISA device from the command line.
> Patch 2 QOM'ifies the device.
> Patches 3 add a Nvram interface to m48txx devices, so that callers can
> detect the device and use it without knowing m48txx internals.
> Patch 4 is using this new Nvram interface and cleaning the m48t59 header.
> 
> Patches 3 and 4 are not needed for m48t59 QOM'ification, but are in my
> opinion a nice cleanup.
> 
> Hervé Poussineau (4):
>   m48t59: move ISA ports/memory regions registration to QOM constructor
>   m48t59: register a QOM type for each nvram type we support
>   m48t59: add a Nvram interface
>   m48t59: let init functions return a Nvram object
> 
>  hw/ppc/ppc.c              |  161 ----------------------
>  hw/ppc/prep.c             |  161 ++++++++++++++++++++--
>  hw/sparc/sun4m.c          |    8 +-
>  hw/sparc64/sun4u.c        |   10 +-
>  hw/timer/m48t59.c         |  336 
> ++++++++++++++++++++++++++++++++-------------
>  include/hw/timer/m48t59.h |   60 ++++----
>  6 files changed, 429 insertions(+), 307 deletions(-)

I've tested this in conjunction with a rebased version of my sun4u NVRAM
changes for SPARC32 and SPARC64 and it looks good so:

Tested-by: Mark Cave-Ayland <address@hidden>

I'll post a new version of my sun4u NVRAM changes rebased on your two
patchsets shortly.


ATB,

Mark.