Re: [Qemu-devel] [PATCH 03/19] qtest/ahci: rename 'Command' to 'CommandHeader'

[Paolo Bonzini]

On 30/01/2015 19:41, John Snow wrote:
> @@ -703,8 +703,8 @@ static void ahci_test_identify(AHCIQState *ahci)
>      /* Copy the existing Command #0 structure from the CLB into local memory,
>       * and build a new command #0. */
>      memread(ahci->port[i].clb, &cmd, sizeof(cmd));
> -    cmd.b1 = 5;    /* reg_h2d_fis is 5 double-words long */
> -    cmd.b2 = 0x04; /* clear PxTFD.STS.BSY when done */
> +    cmd.flags = 5;    /* reg_h2d_fis is 5 double-words long */
> +    cmd.flags |= 0x400; /* clear PxTFD.STS.BSY when done */

Missing cpu_to_le16, I think.

Paolo