[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v8 11/21] replay: recording and replaying cl
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH v8 11/21] replay: recording and replaying clock ticks |
|
Date: |
Tue, 03 Feb 2015 12:59:29 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 03/02/2015 12:23, Pavel Dovgaluk wrote:
> > Only to the cpu_get_ticks usage. The others are okay.
>
> cpu_get_ticks cannot call cpu_get_real_ticks in icount mode.
You're right, but...
> And other functions can.
... which functions? cpu_enable_ticks and cpu_disable_ticks call it,
but the result is only used by cpu_get_ticks. As you said, this cannot
be called in icount mode.
A couple of PPC device models call it, but they probably should call
cpu_get_ticks instead. So it looks like handling REAL_TICKS is
altogether unnecessary.
Paolo