Re: [Qemu-devel] [PATCH v5 11/26] qcow2: More helpers for refcount modification

[Max Reitz]

On 2015-02-04 at 08:53, Kevin Wolf wrote:
> Am 15.12.2014 um 13:50 hat Max Reitz geschrieben:
> > Add helper functions for getting and setting refcounts in a refcount
> > array for any possible refcount order, and choose the correct one during
> > refcount initialization.
> >
> > Signed-off-by: Max Reitz <address@hidden>
> > Reviewed-by: Eric Blake <address@hidden>
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
> Hm... Wouldn't it be better to have a single generic implementation that
> is based on uint64_t* and calculates the right shifts and bitmasks on
> the fly?

Please do try. I tried it, and what I came up with were horrible 
unreadable abominations. I think you can do better, but I don't know 
whether it'll look better than this apparent code duplications.

Max