[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net: synchronize net_host_device_remove with ho
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] net: synchronize net_host_device_remove with host_net_remove_completion |
Date: |
Fri, 6 Feb 2015 13:54:33 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jan 19, 2015 at 12:27:11PM +0100, Paolo Bonzini wrote:
> On 02/01/2015 17:20, Paolo Bonzini wrote:
> >> >
> >> > The assert can be dropped completely since the code already has an
> >> > equivalent assert:
> >> >
> >> > queues = qemu_find_net_clients_except(nc->name, ncs,
> >> > NET_CLIENT_OPTIONS_KIND_NIC,
> >> > MAX_QUEUE_NUM);
> >> > assert(queues != 0); <-- fail if type == NET_CLIENT_OPTIONS_KIND_NIC
> > I left it on purpose for documentation, but I'll send v2 next week that
> > removes it.
>
> Actually it's not the same. If you have "-netdev user,id=e1000 -device
> e1000,netdev=e1000" you will be able to call qemu_del_net_client on the
> NIC, and it will _not_ fail if the assertion is removed.
I don't follow.
If you call qemu_del_net_client(e1000_nic) then
qemu_find_net_clients_except(nc->name, ncs, NET_CLIENT_OPTIONS_KIND_NIC,
MAX_QUEUE_NUM) returns 0. This causes the assert(queues != 0) to fail.
Can you explain the scenario?
Stefan
pgpPn69PUMPnJ.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH] net: synchronize net_host_device_remove with host_net_remove_completion,
Stefan Hajnoczi <=