[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 04/22] quorum: Fix close path
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v2 04/22] quorum: Fix close path |
Date: |
Mon, 9 Feb 2015 13:38:26 -0500 |
bdrv_unref() can lead to bdrv_close(), which in turn will result in
bdrv_drain_all(). This function will later be called blk_drain_all() and
iterate only over the BlockBackends for which blk_is_inserted() holds
true; therefore, bdrv_is_inserted() and thus quorum_is_inserted() will
probably be called.
This patch makes quorum_is_inserted() aware of the fact that some
children may have been closed already.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
block/quorum.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/quorum.c b/block/quorum.c
index 7a75cea..5ae2398 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -1005,6 +1005,7 @@ static void quorum_close(BlockDriverState *bs)
for (i = 0; i < s->num_children; i++) {
bdrv_unref(s->bs[i]);
+ s->bs[i] = NULL;
}
g_free(s->bs);
@@ -1070,7 +1071,7 @@ static bool quorum_is_inserted(BlockDriverState *bs)
int i;
for (i = 0; i < s->num_children; i++) {
- if (!bdrv_is_inserted(s->bs[i])) {
+ if (s->bs[i] && !bdrv_is_inserted(s->bs[i])) {
return false;
}
}
--
2.1.0
- [Qemu-devel] [PATCH v2 00/22] block: Rework bdrv_close_all(), Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 01/22] iotests: Move _filter_nbd into common.filter, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 05/22] block: Move BDS close notifiers into BB, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 08/22] block: Use blk_remove_bs() in blk_delete(), Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 03/22] iotests: Add test for eject under NBD server, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 02/22] iotests: Do not redirect qemu's stderr, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 09/22] blockdev: Use blk_remove_bs() in do_drive_del(), Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 04/22] quorum: Fix close path,
Max Reitz <=
- [Qemu-devel] [PATCH v2 10/22] block: Make bdrv_close() static, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 07/22] block: Add bdrv_close_all() handlers, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 06/22] block: Add bdrv_close_all() notifiers, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 11/22] block: Add blk_name_taken(), Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 14/22] block: Use BlockBackend more, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 12/22] block: Add blk_next_inserted(), Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 13/22] block: Add blk_commit_all() and blk_invalidate_cache_all(), Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 17/22] block: Make bdrv_drain_one() public, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 15/22] blockdev: Add list of monitor-owned BlockBackends, Max Reitz, 2015/02/09