[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 17/37] block: Prepare remaining BB functions
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 17/37] block: Prepare remaining BB functions for NULL BDS |
Date: |
Mon, 09 Feb 2015 13:47:00 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/09/2015 10:11 AM, Max Reitz wrote:
> There are several BlockBackend functions which, in theory, cannot fail.
> This patch makes them cope with the BlockDriverState pointer being NULL
> by making them fall back to some default action like ignoring the value
> in setters and returning the default in getters.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/block-backend.c | 76
> ++++++++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 60 insertions(+), 16 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 03/37] hw/block/fdc: Implement tray status, (continued)
- [Qemu-devel] [PATCH v2 03/37] hw/block/fdc: Implement tray status, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 02/37] iotests: Only create BB if necessary, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 08/37] block: Make bdrv_is_inserted() recursive, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 10/37] block: Move guest_block_size into BlockBackend, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 09/37] block/quorum: Implement bdrv_is_inserted(), Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 11/37] block: Remove wr_highest_sector from BlockAcctStats, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 17/37] block: Prepare remaining BB functions for NULL BDS, Max Reitz, 2015/02/09
- Re: [Qemu-devel] [PATCH v2 17/37] block: Prepare remaining BB functions for NULL BDS,
Eric Blake <=
- [Qemu-devel] [PATCH v2 14/37] block: Add BlockBackendRootState, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 18/37] blockdev: Use BB for blockdev-backup transaction, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 16/37] block: Fail requests to empty BlockBackend, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 13/37] block: Move I/O status and error actions into BB, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 15/37] block: Make some BB functions fall back to BBRS, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 19/37] block: Add blk_insert_bs(), Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 21/37] blockdev: Do not create BDS for empty drive, Max Reitz, 2015/02/09
- [Qemu-devel] [PATCH v2 24/37] block: Add blk_remove_bs(), Max Reitz, 2015/02/09