Re: [Qemu-devel] [RFC v3 06/10] piix: disable all vfio device aercap property

[Alex Williamson]

On Tue, 2015-02-10 at 15:03 +0800, Chen Fan wrote:
> because at i440FX platform, all pcie device don't support aer capability,
> so for all vfio device, we don't need to expose the aer capability.
> 
> Signed-off-by: Chen Fan <address@hidden>
> ---
>  hw/i386/pc_piix.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index 38b42b0..8001313 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -71,6 +71,20 @@ static bool smbios_uuid_encoded = true;
>  static bool gigabyte_align = true;
>  static bool has_reserved_memory = true;
>  
> +static void pc_props_register_global(void) {
> +
> +    static GlobalProperty globalPropertys[] = {
> +       {
> +           .driver   = "vfio-pci",
> +           .property = "aercap",
> +           .value    = "off",
> +        },
> +        { /* end of list */ }
> +    };
> +
> +    qdev_prop_register_global_list(globalPropertys);
> +}
> +

Does this compile?  vfio-pci doesn't have that property until a later
patch.

>  /* PC hardware initialisation */
>  static void pc_init1(MachineState *machine,
>                       int pci_enabled,
> @@ -301,6 +315,8 @@ static void pc_init1(MachineState *machine,
>      if (pci_enabled) {
>          pc_pci_device_init(pci_bus);
>      }
> +
> +    pc_props_register_global();
>  }
>  
>  static void pc_init_pci(MachineState *machine)