[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: vmdk - fixed sizeof() error
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] block: vmdk - fixed sizeof() error |
|
Date: |
Tue, 10 Feb 2015 14:10:21 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/10/2015 11:22 AM, Jeff Cody wrote:
> The size compared should be PATH_MAX, rather than sizeof(char *).
>
> Reported-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> block/vmdk.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 7d079ad..8410a15 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -843,8 +843,7 @@ static int vmdk_parse_extents(const char *desc,
> BlockDriverState *bs,
> }
>
> extent_path = g_malloc0(PATH_MAX);
> - path_combine(extent_path, sizeof(extent_path),
> - desc_file_path, fname);
> + path_combine(extent_path, PATH_MAX, desc_file_path, fname);
> extent_file = NULL;
> ret = bdrv_open(&extent_file, extent_path, NULL, NULL,
> bs->open_flags | BDRV_O_PROTOCOL, NULL, errp);
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature