[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 07/24] qcow2: Helper for refcount array reall
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 07/24] qcow2: Helper for refcount array reallocation |
Date: |
Wed, 11 Feb 2015 11:19:57 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/10/2015 01:28 PM, Max Reitz wrote:
> Add a helper function for reallocating a refcount array, independent of
> the refcount order. The newly allocated space is zeroed and the function
> handles failed reallocations gracefully.
>
> The helper function will always align the buffer size to a cluster
> boundary; if storing the refcounts in such an array in big endian byte
> order, this makes it possible to write parts of the array directly as
> refcount blocks into the image file.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2-refcount.c | 130
> ++++++++++++++++++++++++++++++-------------------
> 1 file changed, 81 insertions(+), 49 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v6 04/24] qcow2: Only return status from qcow2_get_refcount, (continued)
- [Qemu-devel] [PATCH v6 05/24] qcow2: Use unsigned addend for update_refcount(), Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 06/24] qcow2: Use 64 bits for refcount values, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 10/24] qcow2: Open images with refcount order != 4, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 08/24] qcow2: Helper function for refcount modification, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 12/24] qcow2: Use symbolic macros in qcow2_amend_options, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 07/24] qcow2: Helper for refcount array reallocation, Max Reitz, 2015/02/10
- Re: [Qemu-devel] [PATCH v6 07/24] qcow2: Helper for refcount array reallocation,
Eric Blake <=
- [Qemu-devel] [PATCH v6 09/24] qcow2: More helpers for refcount modification, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 13/24] iotests: Prepare for refcount_bits option, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 15/24] progress: Allow regressing progress, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 11/24] qcow2: refcount_order parameter for qcow2_create2, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 20/24] qcow2: Use intermediate helper CB for amend, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 16/24] block: Add opaque value to the amend CB, Max Reitz, 2015/02/10
- [Qemu-devel] [PATCH v6 14/24] qcow2: Allow creation with refcount order != 4, Max Reitz, 2015/02/10