[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] Add migrate_incoming
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] Add migrate_incoming |
Date: |
Wed, 11 Feb 2015 19:24:36 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
Eric Blake <address@hidden> wrote:
> On 02/11/2015 09:46 AM, Dr. David Alan Gilbert (git) wrote:
>> From: "Dr. David Alan Gilbert" <address@hidden>
>>
>> Add migrate_incoming/migrate-incoming to start an incoming
>> migration.
>>
>> Once a qemu has been started with
>> -incoming pause
>>
>> the migration can be started by issuing:
>> migrate_incoming uri
>>
>> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
>> ---
>> hmp-commands.hx | 16 ++++++++++++++++
>> hmp.c | 14 ++++++++++++++
>> hmp.h | 1 +
>> migration/migration.c | 19 +++++++++++++++++++
>> qapi-schema.json | 15 +++++++++++++++
>> qmp-commands.hx | 31 ++++++++++++++++++++++++++++++-
>> 6 files changed, 95 insertions(+), 1 deletion(-)
>>
>
>> +++ b/migration/migration.c
>> @@ -432,6 +432,25 @@ void migrate_del_blocker(Error *reason)
>> migration_blockers = g_slist_remove(migration_blockers, reason);
>> }
>>
>> +void qmp_migrate_incoming(const char *uri, Error **errp)
>> +{
>> + Error *local_err = NULL;
>> +
>> + if (!paused_incoming) {
>> + error_setg(errp, "-incoming pause is required for
>> migrate_incoming");
>
> Might read easier as "'-incoming pause' is required...", but that's minor.
>
> Reviewed-by: Eric Blake <address@hidden>
As this is a very minor fix, I apply it by hand on my tree.
Thanks to all reviewers.
Applied, Juan.