qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] hw/arm/virt: "bus-range"/end is off by one


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: "bus-range"/end is off by one
Date: Fri, 13 Feb 2015 01:13:45 +0000

On 13 February 2015 at 01:12, Alexander Graf <address@hidden> wrote:
>
>
> On 12.02.15 19:50, Laszlo Ersek wrote:
>> According to "PCI Bus Binding to IEEE Std 1275-1994", 3.1.2. Bus-specific
>> Properties for Bus Nodes, the second integer in "bus-range" is an
>> inclusive limit.
>>
>> This seems to be consistent with several *.dtsi files in the kernel tree,
>> where examples like
>>
>>   bus-range = <0 0>;
>>
>> are visible.
>>
>> In addition, the loop in gen_pci_parse_map_cfg_windows()
>> [drivers/pci/host/pci-host-generic.c] uses "bus_range->end" as an
>> inclusive limit.
>>
>> Signed-off-by: Laszlo Ersek <address@hidden>
>
> Nice catch!
>
> Reviewed-by: Alexander Graf <address@hidden>

Since I haven't pushed the pci patches yet I'll just squash
this fix in to them.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]