Re: [Qemu-devel] [PATCH v7 0/5] block: Add a qemu-iotests case for IO throttling

[Stefan Hajnoczi]

On Fri, Jan 30, 2015 at 10:49:41AM +0800, Fam Zheng wrote:
> v7: Remove any "{iops,bps}_max" in 093 completely. (Max)
> 
> v6: Less resource demanding patch 5. (Max)
>     Add rev-by of Max to other patches.
> 
> v5: Rebase and improve the test. Please review again.
> 
>     Patch dependencies:
> 
>     This test depends on the qtest timer fix to run correctly.
>     http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01865.html
> 
>     Also depends on the os check fix to run at all:
>     http://lists.gnu.org/archive/html/qemu-devel/2015-01/msg01848.html
> 
> Original cover letter
> ---------------------
> 
> There is a change in qemu-io sub-commands "aio_read" and "aio_write", which
> makes the aio requests accounted and the statistics reflected in blockstats.
> 
> Note that IO throttling implementation allows overcommiting of requests, so 
> the
> actual IO happened in a time unit may be a bit larger than given limits. In 
> the
> test case, the stats numbers are compared with a 10% error tolerance, to make
> room for such flexibility in order to improve determinism.
> 
> Fam
> 
> 
> Fam Zheng (5):
>   qemu-io: Account IO by aio_read and aio_write
>   qtest: Add scripts/qtest.py
>   qemu-iotests: Add VM method qtest() to iotests.py
>   qemu-iotests: Allow caller to disable underscore convertion for qmp
>   qemu-iotests: Add 093 for IO throttling
> 
>  qemu-io-cmds.c                |  11 ++++
>  scripts/qtest.py              |  71 ++++++++++++++++++++++++++
>  tests/qemu-iotests/093        | 114 
> ++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/093.out    |   5 ++
>  tests/qemu-iotests/group      |   1 +
>  tests/qemu-iotests/iotests.py |  23 +++++++--
>  6 files changed, 221 insertions(+), 4 deletions(-)
>  create mode 100644 scripts/qtest.py
>  create mode 100755 tests/qemu-iotests/093
>  create mode 100644 tests/qemu-iotests/093.out
> 
> -- 
> 1.9.3
> 

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

pgpLIvA3qjpzu.pgp
Description: PGP signature