[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/7] vnc: fix qemu crash when not configure vnc optio
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 1/7] vnc: fix qemu crash when not configure vnc option |
Date: |
Mon, 16 Feb 2015 09:25:59 +0100 |
From: Gonglei <address@hidden>
Add missing vnc options: to, ipv4, ipv6 and fix
qemu crash.
Reproducer:
$ x86_64-softmmu/qemu-system-x86_64
qemu-system-x86_64: Invalid parameter 'to'
Segmentation fault (core dumped)
BTW the patch fix the below bug:
https://bugs.launchpad.net/qemu/+bug/1414222
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Don Slutz <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/vnc.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/ui/vnc.c b/ui/vnc.c
index 02552ee..90e8a88 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3272,6 +3272,15 @@ static QemuOptsList qemu_vnc_opts = {
.name = "connections",
.type = QEMU_OPT_NUMBER,
},{
+ .name = "to",
+ .type = QEMU_OPT_NUMBER,
+ },{
+ .name = "ipv4",
+ .type = QEMU_OPT_BOOL,
+ },{
+ .name = "ipv6",
+ .type = QEMU_OPT_BOOL,
+ },{
.name = "password",
.type = QEMU_OPT_BOOL,
},{
--
1.8.3.1
- [Qemu-devel] [PULL 0/7] vnc: fixup some QemuOpts conversion fallout., Gerd Hoffmann, 2015/02/16
- [Qemu-devel] [PULL 3/7] vnc: using bool type instead of int for QEMU_OPT_BOOL, Gerd Hoffmann, 2015/02/16
- [Qemu-devel] [PULL 1/7] vnc: fix qemu crash when not configure vnc option,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 7/7] vnc: fix coverity warning, Gerd Hoffmann, 2015/02/16
- [Qemu-devel] [PULL 2/7] vnc: correct missing property about vnc_display, Gerd Hoffmann, 2015/02/16
- [Qemu-devel] [PULL 5/7] vnc: auto assian an id when calling change vnc qmp interface, Gerd Hoffmann, 2015/02/16
- [Qemu-devel] [PULL 6/7] ui/vnc: optimize full scanline updates, Gerd Hoffmann, 2015/02/16
- [Qemu-devel] [PULL 4/7] vnc: introduce an wrapper for auto assign vnc id, Gerd Hoffmann, 2015/02/16
- Re: [Qemu-devel] [PULL 0/7] vnc: fixup some QemuOpts conversion fallout., Peter Maydell, 2015/02/24