[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers |
Date: |
Mon, 16 Feb 2015 12:36:18 +0100 |
On Mon, Feb 16, 2015 at 10:30:24AM +0100, Paolo Bonzini wrote:
>
>
> On 15/02/2015 12:39, Michael S. Tsirkin wrote:
> > Drop duplicated code.
> >
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > ---
> > include/hw/virtio/virtio-scsi.h | 120
> > +++-------------------------------------
> > hw/scsi/virtio-scsi.c | 1 +
> > 2 files changed, 10 insertions(+), 111 deletions(-)
> >
> > diff --git a/include/hw/virtio/virtio-scsi.h
> > b/include/hw/virtio/virtio-scsi.h
> > index bf17cc9..9bcda7e 100644
> > --- a/include/hw/virtio/virtio-scsi.h
> > +++ b/include/hw/virtio/virtio-scsi.h
> > @@ -14,6 +14,7 @@
> > #ifndef _QEMU_VIRTIO_SCSI_H
> > #define _QEMU_VIRTIO_SCSI_H
> >
> > +#include "standard-headers/sys/virtio_scsi.h"
>
> Why sys/? It's linux/, let's keep it linux/.
>
> Paolo
Peter requested this change: he felt having portable
headers under linux/ is confusing:
http://mid.gmane.org/address@hidden
Makes sense?
--
MST
- Re: [Qemu-devel] [PATCH v2 02/17] include: import virtio headers from linux 4.0, (continued)
- [Qemu-devel] [PATCH v2 04/17] virtio: use standard-headers, Michael S. Tsirkin, 2015/02/15
- [Qemu-devel] [PATCH v2 05/17] virtio-balloon: use standard headers, Michael S. Tsirkin, 2015/02/15
- [Qemu-devel] [PATCH v2 06/17] virtio-9p: use standard headers, Michael S. Tsirkin, 2015/02/15
- [Qemu-devel] [PATCH v2 07/17] virtio-blk: switch to standard-headers, Michael S. Tsirkin, 2015/02/15
- [Qemu-devel] [PATCH v2 09/17] virtio-rng: use standard-headers, Michael S. Tsirkin, 2015/02/15
- [Qemu-devel] [PATCH v2 08/17] virtio-net, tap: use standard-headers, Michael S. Tsirkin, 2015/02/15
- [Qemu-devel] [PATCH v2 10/17] virtio-scsi: use standard-headers, Michael S. Tsirkin, 2015/02/15
[Qemu-devel] [PATCH v2 11/17] virtio-serial: switch to standard-headers, Michael S. Tsirkin, 2015/02/15
[Qemu-devel] [PATCH v2 12/17] update-linux-headers: use standard-headers, Michael S. Tsirkin, 2015/02/15
[Qemu-devel] [PATCH v2 13/17] linux-headers: use standard-headers, Michael S. Tsirkin, 2015/02/15
[Qemu-devel] [PATCH v2 14/17] virtio-pci: use standard headers, Michael S. Tsirkin, 2015/02/15
[Qemu-devel] [PATCH v2 15/17] scripts: add arch specific standard-headers, Michael S. Tsirkin, 2015/02/15
[Qemu-devel] [PATCH v2 16/17] standard-headers: add s390 virtio headers, Michael S. Tsirkin, 2015/02/15