Re: [Qemu-devel] [PATCH 02/13] QemuOpts: Convert qemu_opt_set_number() to Error, fix its use

[Eric Blake]

On 02/16/2015 07:44 AM, Markus Armbruster wrote:
> Return the Error object instead of reporting it with
> qerror_report_err().
> 
> Change callers that assume the function can't fail to pass
> &error_abort, so that should the assumption ever break, it'll break
> noisily.
> 
> Turns out all callers outside its unit test assume that.  We could
> drop the Error ** argument, but that would make the interface less
> regular, so don't.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  block.c                |  6 +++---
>  block/nbd.c            |  3 ++-
>  block/qcow2.c          |  2 +-
>  block/vvfat.c          |  3 ++-
>  include/qemu/option.h  |  3 ++-
>  qemu-img.c             |  3 ++-
>  tests/test-qemu-opts.c | 16 ++++++++--------
>  util/qemu-option.c     |  9 ++++-----
>  vl.c                   |  2 +-
>  9 files changed, 25 insertions(+), 22 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature