[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 31/52] acpi: add aml_local() term
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v3 31/52] acpi: add aml_local() term |
Date: |
Tue, 17 Feb 2015 13:18:19 +0100 |
On Mon, Feb 09, 2015 at 10:53:53AM +0000, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
This causes asserts.
> hw/acpi/aml-build.c | 11 +++++++++++
> include/hw/acpi/aml-build.h | 1 +
> 2 files changed, 12 insertions(+)
>
> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> index 10995a9..cb58e19 100644
> --- a/hw/acpi/aml-build.c
> +++ b/hw/acpi/aml-build.c
> @@ -647,3 +647,14 @@ Aml *aml_field(const char *name, AmlFieldFlags flags)
> build_append_byte(var->buf, flags);
> return var;
> }
> +
> +/* ACPI 1.0b: 16.2.6.2 Local Objects Encoding */
> +Aml *aml_local(int num)
> +{
> + Aml *var;
> + uint8_t op = 0x60 /* Local0Op */ + num;
So op is 0x6X here.
> +
> + assert(op <= 7);
And here we assert it is <= 7?
> + var = aml_opcode(op);
> + return var;
> +}
> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
> index 8b954d9..6e25315 100644
> --- a/include/hw/acpi/aml-build.h
> +++ b/include/hw/acpi/aml-build.h
> @@ -101,6 +101,7 @@ Aml *aml_io(AmlIODecode dec, uint16_t min_base, uint16_t
> max_base,
> Aml *aml_operation_region(const char *name, AmlRegionSpace rs,
> uint32_t offset, uint32_t len);
> Aml *aml_named_field(const char *name, unsigned length);
> +Aml *aml_local(int num);
>
> /* Block AML object primitives */
> Aml *aml_def_block(const char *signature, uint8_t revision,
> --
> 1.8.3.1
- [Qemu-devel] [PATCH v3 22/52] acpi: add aml_package() term, (continued)
- [Qemu-devel] [PATCH v3 22/52] acpi: add aml_package() term, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 18/52] acpi: add aml_and() term, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 21/52] pc: acpi-build: drop template patching and create PCI bus tree dynamically, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 23/52] pc: acpi-build: drop unsupported PM1b_CNT.SLP_TYP, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 25/52] acpi: add aml_buffer() term, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 28/52] acpi: include PkgLength size only when requested, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 24/52] pc: acpi-build: generate _S[345] packages dynamically, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 30/52] acpi: add aml_field() & aml_named_field() terms, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 27/52] acpi: add aml_io() helper, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 31/52] acpi: add aml_local() term, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 29/52] acpi: add aml_operation_region() term, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 34/52] acpi: add aml_varpackage() term, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 36/52] acpi: add aml_processor() term, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 26/52] acpi: add aml_resource_template() helper, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 35/52] acpi: add aml_equal() term, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 37/52] acpi: add aml_eisaid() term, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 38/52] pc: acpi-build: drop template patching and CPU hotplug objects dynamically, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 40/52] acpi: add aml_reserved_field() term, Igor Mammedov, 2015/02/09