[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/10] qga: introduce three guest memory block c
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 05/10] qga: introduce three guest memory block commmands with stubs |
Date: |
Tue, 17 Feb 2015 08:26:12 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 02/16/2015 08:14 PM, Michael Roth wrote:
> From: zhanghailiang <address@hidden>
>
> Introduce three new guest commands:
> guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size.
Sorry for the late review, but I think guest-get-memory-block-size is
the wrong command to add.
> +##
> +# @guest-get-memory-block-size:
> +#
> +# Get the the size (in bytes) of a memory block in guest.
> +# It is the unit of memory block online/offline operation (also called
> Logical
> +# Memory Hotplug).
> +#
> +# Returns: memory block size in bytes.
> +#
> +# Since 2.3
> +##
> +{ 'command': 'guest-get-memory-block-size',
> + 'returns': 'int' }
Any QAPI command that returns a bare int instead of a dictionary is
non-extensible, and therefore of suspect design. I think it would be
better to have:
{ 'command': 'guest-get-memory-block-info',
'returns': { 'size': 'int' } }
to allow for future extension.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 00/10] Fixes and new commands for QEMU Guest Agent, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 10/10] qemu-ga-win: Fail loudly on bare 'set-time', Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 01/10] qga: add guest-set-user-password command, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 02/10] utils: drop strtok_r from envlist_parse, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 09/10] qga: add memory block command that unsupported, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 04/10] qga: implement file commands for Windows guest, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 05/10] qga: introduce three guest memory block commmands with stubs, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 07/10] qga: implement qmp_guest_set_memory_blocks() for Linux with sysfs, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 06/10] qga: implement qmp_guest_get_memory_blocks() for Linux with sysfs, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring, Michael Roth, 2015/02/16