[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/52] ACPI refactoring: replace template pat
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/52] ACPI refactoring: replace template patching with C AML API |
Date: |
Tue, 17 Feb 2015 20:14:06 +0100 |
On Tue, Feb 17, 2015 at 06:51:16PM +0100, Igor Mammedov wrote:
> On Tue, 17 Feb 2015 17:47:03 +0100
> "Michael S. Tsirkin" <address@hidden> wrote:
>
> > This seems to change the contents of the tables in too many ways. So of
> > it needs changing since PCI are somewhat broken by your recent patch.
> In which way is it broken?
Try make check and look at the diffs.
They shouldn't be so big.
I want differences to be trivial, e.g.
0->Zero would be ok.
Refactoring code generation should be separate from
changing generated code.
> >
> > So let's do this: please prepare a minimal patchset that just generates
> > PCI description dynamically. Drop everything that's not necessary, and
> > verify that make check produces trivial diffs only.
> >
> > We'll go from there.
> >
- [Qemu-devel] [PATCH v3 46/52] pc: acpi-build: create PCI0._CRS dynamically, (continued)
- [Qemu-devel] [PATCH v3 46/52] pc: acpi-build: create PCI0._CRS dynamically, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 33/52] pc: acpi-build: generate pvpanic device description dynamically, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 45/52] pc: acpi-build: reserve PCIHP MMIO resources, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 51/52] pc: acpi-build: update [q35-]acpi-dsdt.hex.generated due to moved SMC, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 39/52] pc: acpi-build: create CPU hotplug IO region dynamically, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 48/52] acpi: add acpi_irq_no_flags() term, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 49/52] pc: export applesmc IO port/len, Igor Mammedov, 2015/02/09
- [Qemu-devel] [PATCH v3 50/52] pc: acpi-build: drop template patching and create Device(SMC) dynamically, Igor Mammedov, 2015/02/09
- Re: [Qemu-devel] [PATCH v3 00/52] ACPI refactoring: replace template patching with C AML API, Michael S. Tsirkin, 2015/02/17