Re: [Qemu-devel] [PATCH v3 09/17] virtio-rng: use standard-headers

[Thomas Huth]

On Mon, 16 Feb 2015 22:36:15 +0100
"Michael S. Tsirkin" <address@hidden> wrote:

> Drop duplicated code.
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>  include/hw/virtio/virtio-rng.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/hw/virtio/virtio-rng.h b/include/hw/virtio/virtio-rng.h
> index 14e85a5..7702ff4 100644
> --- a/include/hw/virtio/virtio-rng.h
> +++ b/include/hw/virtio/virtio-rng.h
> @@ -14,6 +14,7 @@
> 
>  #include "sysemu/rng.h"
>  #include "sysemu/rng-random.h"
> +#include "standard-headers/linux/virtio_rng.h"
> 
>  #define TYPE_VIRTIO_RNG "virtio-rng-device"
>  #define VIRTIO_RNG(obj) \
> @@ -21,9 +22,6 @@
>  #define VIRTIO_RNG_GET_PARENT_CLASS(obj) \
>          OBJECT_GET_PARENT_CLASS(obj, TYPE_VIRTIO_RNG)
> 
> -/* The Virtio ID for the virtio rng device */
> -#define VIRTIO_ID_RNG    4
> -
>  struct VirtIORNGConf {
>      RngBackend *rng;
>      uint64_t max_bytes;

Reviewed-by: Thomas Huth <address@hidden>