[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 6/8] r2d: Don't use legacy -usbdevice support for set
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 6/8] r2d: Don't use legacy -usbdevice support for setting up board |
Date: |
Wed, 18 Feb 2015 11:08:23 +0100 |
From: Markus Armbruster <address@hidden>
It's tempting, because usbdevice_create() is so simple to use. But
there's a lot of unwanted complexity behind the simple interface.
Switch to usb_create_simple().
Cc: Magnus Damm <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/sh4/r2d.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c
index 12f44d2..d1d0847 100644
--- a/hw/sh4/r2d.c
+++ b/hw/sh4/r2d.c
@@ -301,7 +301,7 @@ static void r2d_init(MachineState *machine)
"rtl8139", i==0 ? "2" : NULL);
/* USB keyboard */
- usbdevice_create("keyboard");
+ usb_create_simple(usb_bus_find(-1), "usb-kbd");
/* Todo: register on board registers */
memset(&boot_params, 0, sizeof(boot_params));
--
1.8.3.1
- [Qemu-devel] [PULL 0/8] usb: error handling fixes from Markus, make sysbus ehci arm-only., Gerd Hoffmann, 2015/02/18
- [Qemu-devel] [PULL 7/8] PPC: Don't use legacy -usbdevice support for setting up board, Gerd Hoffmann, 2015/02/18
- [Qemu-devel] [PULL 8/8] Make sysbus EHCI devices ARM only by default, Gerd Hoffmann, 2015/02/18
- [Qemu-devel] [PULL 2/8] usb: Improve -usbdevice error reporting a bit, Gerd Hoffmann, 2015/02/18
- [Qemu-devel] [PULL 4/8] usb: Suppress bogus error when automatic usb-hub creation fails, Gerd Hoffmann, 2015/02/18
- [Qemu-devel] [PULL 5/8] usb: Change usb_create_simple() to abort on failure, Gerd Hoffmann, 2015/02/18
- [Qemu-devel] [PULL 1/8] usb: usb_create() can't fail, drop useless error handling, Gerd Hoffmann, 2015/02/18
- [Qemu-devel] [PULL 6/8] r2d: Don't use legacy -usbdevice support for setting up board,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 3/8] usb: Do not prefix error_setg() messages with "Error: ", Gerd Hoffmann, 2015/02/18
- Re: [Qemu-devel] [PULL 0/8] usb: error handling fixes from Markus, make sysbus ehci arm-only., Peter Maydell, 2015/02/25