qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH 09/14] block: give backing image its own Blo


From: Max Reitz
Subject: Re: [Qemu-devel] [RFC PATCH 09/14] block: give backing image its own BlockBackend
Date: Mon, 23 Feb 2015 16:53:58 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0

On 2015-02-11 at 22:07, Wen Congyang wrote:
Signed-off-by: Wen Congyang <address@hidden>
Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Gonglei <address@hidden>
---
  block.c | 11 +++++++----
  1 file changed, 7 insertions(+), 4 deletions(-)

Our current stance on BlockBackends is (as far as I know, anyway) that a BlockBackend always comes with a user. In case you're creating a BlockBackend through -drive or blockdev-add, the user is the monitor (which can use it to attach it to a device, for instance). In this case, there is no user and nobody holds a reference to the BB (other than the BDS, but that doesn't count).

Therefore, this patch doesn't look quite right.

Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]