[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 13/16] spapr_pci: populate DRC dt entries for
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH v5 13/16] spapr_pci: populate DRC dt entries for PHBs |
Date: |
Tue, 24 Feb 2015 12:52:10 -0600 |
User-agent: |
alot/0.3.4 |
Quoting David Gibson (2015-02-24 03:29:40)
> On Mon, Feb 16, 2015 at 08:27:49AM -0600, Michael Roth wrote:
> > Reserve 32 entries of type PCI in each PHB's initial FDT. This
>
> I find this description odd. It's not reallky reserving anything,
> just publishing the DRCs you already created in the FDT.
Yah, I think this is an artifact from earlier versions where we
reserved the entries statically.
>
> I wonder if this should be merged with the previous patch.
Makes sense. Will fix up the description and merge this into
previous patch.
>
> > advertises to guests that each PHB is DR-capable device with
> > physical hotpluggable slots. This is necessary for allowing
> > hotplugging of devices to it later via bus rescan or guest rpaphp
> > hotplug module.
> >
> > Signed-off-by: Michael Roth <address@hidden>
>
> But, it looks correct.
>
> Reviewed-by: David Gibson <address@hidden>
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson
- Re: [Qemu-devel] [PATCH v5 10/16] spapr_drc: add spapr_drc_populate_dt(), (continued)
- [Qemu-devel] [PATCH v5 09/16] spapr_events: event-scan RTAS interface, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH v5 14/16] pci: make pci_bar useable outside pci.c, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH v5 15/16] spapr_pci: enable basic hotplug operations, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH v5 01/16] docs: add sPAPR hotplug/dynamic-reconfiguration documentation, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH v5 16/16] spapr_pci: emit hotplug add/remove events during hotplug, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH v5 13/16] spapr_pci: populate DRC dt entries for PHBs, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH v5 11/16] spapr_pci: add dynamic-reconfiguration option for spapr-pci-host-bridge, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH v5 12/16] spapr_pci: create DRConnectors for each PCI slot during PHB realize, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH v5 04/16] spapr_rtas: add set-indicator RTAS interface, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH v5 06/16] spapr: add rtas_st_buffer_direct() helper, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH v5 02/16] spapr_drc: initial implementation of sPAPRDRConnector device, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH v5 03/16] spapr_rtas: add get/set-power-level RTAS interfaces, Michael Roth, 2015/02/16
- [Qemu-devel] [PATCH v5 05/16] spapr_rtas: add get-sensor-state RTAS interface, Michael Roth, 2015/02/16