[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 08/11] virtio-pci: switch to use bus specific
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH V2 08/11] virtio-pci: switch to use bus specific queue limit |
Date: |
Thu, 26 Feb 2015 11:20:07 +0100 |
On Thu, Feb 26, 2015 at 03:04:43PM +0800, Jason Wang wrote:
> Instead of depending on a macro, switch to use a bus specific queue
> limit.
>
> Cc: Anthony Liguori <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Jason Wang <address@hidden>
> ---
> hw/virtio/virtio-pci.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index 7fa8141..23c4649 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -215,7 +215,7 @@ static void virtio_pci_start_ioeventfd(VirtIOPCIProxy
> *proxy)
> return;
> }
>
> - for (n = 0; n < VIRTIO_PCI_QUEUE_MAX; n++) {
> + for (n = 0; n < virtio_get_queue_max(vdev); n++) {
> if (!virtio_queue_get_num(vdev, n)) {
> continue;
> }
This is done on guest IO, and I think after applying the
next patch which increases the number to >500 for pci, it's too much
work: VCPU is blocked meanwhile. Same applies to other places.
At minimum, we'll need a faster way to locate active VQs.
--
MST
- Re: [Qemu-devel] [PATCH V2 03/11] virito: introduce bus specific queue limit, (continued)
- [Qemu-devel] [PATCH V2 05/11] virtio-serial-bus: switch to bus specific queue limit, Jason Wang, 2015/02/26
- [Qemu-devel] [PATCH V2 04/11] virtio-ccw: introduce ccw specific queue limit, Jason Wang, 2015/02/26
- [Qemu-devel] [PATCH V2 07/11] virtio-mmio: switch to bus specific queue limit, Jason Wang, 2015/02/26
- [Qemu-devel] [PATCH V2 06/11] virtio-s390: switch to bus specific queue limit, Jason Wang, 2015/02/26
- [Qemu-devel] [PATCH V2 09/11] virtio-pci: increase the maximum number of virtqueues to 513, Jason Wang, 2015/02/26
- [Qemu-devel] [PATCH V2 08/11] virtio-pci: switch to use bus specific queue limit, Jason Wang, 2015/02/26
- Re: [Qemu-devel] [PATCH V2 08/11] virtio-pci: switch to use bus specific queue limit,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH V2 10/11] pci: remove hard-coded bar size in msix_init_exclusive_bar(), Jason Wang, 2015/02/26
- [Qemu-devel] [PATCH V2 11/11] virtio-pci: introduce auto_msix_bar_size property, Jason Wang, 2015/02/26