[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of MigrationInfo to use an enum type |
Date: |
Wed, 04 Mar 2015 08:48:23 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 03/03/2015 12:15 AM, zhanghailiang wrote:
>
>>>>
>>>> Yes, this is the reason ..., agreed, i don't like the abbreviate,
>>>> But there is already a 'MigrationState' type defined:
>>>>
>>>
>>>>
>>>> So, what about MigrationStatus ? ;)
>>>
>>> That would be fine with me.
>>>
>>
>> Bad news, this name has also been used :(
>>
>> In hmp.c:
>>
>> typedef struct MigrationStatus
>
> You know, you could always rename the internal-only conflict into
> something else so that the publicly exported typename is nice. Yeah,
> that makes the series longer,
by *two* patch hunks updating the four occurences of MigrationStatus,
> but it should be all mechanical
> conversions, right? I'm not going to be too picky about what color we
> paint this bikeshed, though.
Me neither, but we shouldn't compromise on external interfaces just to
avoid a bit of internal churn. Pick a good name, then do what it takes.