[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/4] migration: Convert 'status' of Migration
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 3/4] migration: Convert 'status' of MigrationInfo to use an enum type |
|
Date: |
Fri, 06 Mar 2015 09:17:34 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 03/04/2015 07:09 AM, zhanghailiang wrote:
> The original 'status' is an open-coded 'str' type, convert it to use an
> enum type.
> This conversion is backwards compatible, better documented and
> more convenient for future extensibility.
>
> We also rename 'MIGRATION_STATUS_ERROR' to 'MIGRATION_STATUS_FAILED'.
I argue that this change should be done in 1/4.
> In addition, Fix a typo for qapi-schema.json: comppleted -> completed
but this one can stay here.
>
> Signed-off-by: zhanghailiang <address@hidden>
> ---
> hmp.c | 7 ++++---
> migration/migration.c | 34 ++++++++++++----------------------
> qapi-schema.json | 34 +++++++++++++++++++++++++++++-----
> 3 files changed, 45 insertions(+), 30 deletions(-)
>
Otherwise, modulo Markus' review, it's looking better.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature