qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value


From: Yik Fang
Subject: Re: [Qemu-devel] [PATCH] nbd: Fix overflow return value
Date: Mon, 9 Mar 2015 10:16:07 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

Thanks to Markus for your help!


On 2015/3/2 9:25, Fangyi (C) wrote:
PING
The value of reply.error should be the type unsigned int.

Signed-off-by: Yik Fang <address@hidden>
---
  nbd.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nbd.c b/nbd.c
index e56afbc1..30e2f3b 100644
--- a/nbd.c
+++ b/nbd.c
@@ -1295,7 +1295,7 @@ static void nbd_trip(void *opaque)
      default:
          LOG("invalid request type (%u) received", request.type);
      invalid_request:
-        reply.error = -EINVAL;
+        reply.error = EINVAL;
      error_reply:
          if (nbd_co_send_reply(req, &reply, 0) < 0) {
              goto out;
-- 1.8.5








reply via email to

[Prev in Thread] Current Thread [Next in Thread]