Re: [Qemu-devel] [PATCH V3 08/14] virtio-pci: switch to use bus specific queue limit

[Cornelia Huck]

On Mon, 09 Mar 2015 15:32:51 +0800
Jason Wang <address@hidden> wrote:

> 
> 
> On Fri, Mar 6, 2015 at 8:28 PM, Cornelia Huck 
> <address@hidden> wrote:
> > On Thu,  5 Mar 2015 13:48:45 +0800
> > Jason Wang <address@hidden> wrote:
> > 
> >>  Instead of depending on a macro, switch to use a bus specific queue
> >>  limit.
> >>  
> >>  Cc: Anthony Liguori <address@hidden>
> >>  Cc: Michael S. Tsirkin <address@hidden>
> >>  Signed-off-by: Jason Wang <address@hidden>
> >>  ---
> >>   hw/virtio/virtio-pci.c     | 12 +++++++-----
> >>   include/hw/virtio/virtio.h |  1 -
> >>   2 files changed, 7 insertions(+), 6 deletions(-)
> >>  
> > 
> >>  diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
> >>  index 04ad532..9a81edf 100644
> >>  --- a/include/hw/virtio/virtio.h
> >>  +++ b/include/hw/virtio/virtio.hs
> >>  @@ -92,7 +92,6 @@ typedef struct VirtQueueElement
> >>       struct iovec out_sg[VIRTQUEUE_MAX_SIZE];
> >>   } VirtQueueElement;
> >>  
> >>  -#define VIRTIO_PCI_QUEUE_MAX 64
> >>   #define VIRTIO_CCW_QUEUE_MAX 64
> > 
> > This hunk makes me think that the ccw limit shouldn't have been added
> > here :)
> 
> Yes, fail to find a common header at first try. But looks like I can 
> move this in include/hw/s390x/s390_flic.h.
> 

Hm, I'm not 100% sure about that. Maybe if we introduce a #gsi define
there and have virtio-ccw inherit that as queue limit? Having a virtio
limit in the flic header feels a bit odd.