[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu.
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu. |
Date: |
Wed, 11 Mar 2015 07:19:35 +0100 |
On Wed, Mar 11, 2015 at 04:29:30PM +1030, Rusty Russell wrote:
> The virtio 'used' ring describes descriptors which have been used. It
> also says how many bytes have been written to the ring. For some cases,
> this value is ignored by Linux guests, thus errors have not been noticed.
> I was working on increasing the checking in Linux when I noticed this
> behaviour.
>
> The first patch changes the 'len' formal parameter name to 'len_written' to
> make the API clearer, and adds an assert(). The second fixes block writes.
>
> Cheers,
> Rusty.
> PS. It's based on MST's virtio-1.0 tree, but should be easily ported.
Thanks, this applies to current master without issues.
However, I think it's best to apply patch 2, then patch 1,
to avoid triggering errors when bisecting.
> Rusty Russell (2):
> virtio: make it clear that "len" for a used descriptor is len written.
> virtio-blk: fix length calculations for write operations.
>
> hw/block/virtio-blk.c | 9 ++++++++-
> hw/virtio/virtio.c | 19 ++++++++++++-------
> include/hw/virtio/virtio.h | 4 ++--
> 3 files changed, 22 insertions(+), 10 deletions(-)
>
> --
> 2.1.0
- [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu., Rusty Russell, 2015/03/11
- [Qemu-devel] [PATCH 1/2] virtio: make it clear that "len" for a used descriptor is len written., Rusty Russell, 2015/03/11
- [Qemu-devel] [PATCH 2/2] virtio-blk: fix length calculations for write operations., Rusty Russell, 2015/03/11
- Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu.,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu., Fam Zheng, 2015/03/11
- Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu., Michael S. Tsirkin, 2015/03/11
- Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu., Rusty Russell, 2015/03/11
- Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu., Michael S. Tsirkin, 2015/03/11
- Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu., Rusty Russell, 2015/03/11
- Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu., Michael S. Tsirkin, 2015/03/12
- Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu., Rusty Russell, 2015/03/12
- Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu., Michael S. Tsirkin, 2015/03/13
- Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu., Rusty Russell, 2015/03/15
- Re: [Qemu-devel] [PATCH 0/2] virtio len fixes for qemu., Michael S. Tsirkin, 2015/03/16