[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/1] target-i386: Remove icc_bridge parameter
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create() |
Date: |
Wed, 11 Mar 2015 10:49:41 -0300 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Mar 11, 2015 at 02:36:08PM +0100, Igor Mammedov wrote:
[...]
> > - cpu = cpu_x86_create(cpu_model, icc_bridge, &local_err);
> > + if (icc_bridge == NULL) {
> turn it into assert(icc_bridge != NULL)
> that should never be NULL or we have a codding error somewhere in code.
See changelog and the v1 discussion:
> > Changes v1 -> v2:
> > * Keep existing check for NULL icc_bridge and error reporting, instead
> > of assing assert(icc_bridge)
(I just noticed the typo, and it was _not_ intentional :)
--
Eduardo
[Qemu-devel] [PATCH for-next] pc: Ensure non-zero CPU ref count after attaching to ICC bus, Andreas Färber, 2015/03/17